Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize OCP 4.14 spec #488

Closed
11 tasks done
travier opened this issue Sep 6, 2023 · 4 comments · Fixed by #491
Closed
11 tasks done

Stabilize OCP 4.14 spec #488

travier opened this issue Sep 6, 2023 · 4 comments · Fixed by #491
Assignees
@prestist @travier
Labels
jira

Comments

@travier
Copy link
Member

travier commented Sep 6, 2023 •
edited

Bumping spec versions

Bump distro version

  • Rename config/distro/vD_exp to config/distro/vD and update package statements. Update imports.
  • Drop -experimental from init() in config/config.go.
  • Drop -experimental from examples in docs/.
  • Copy config/distro/vD to config/distro/vD+1_exp.
  • Update package statements in config/distro/vD+1_exp. Bump its base dependency to base/vB+1_exp.
  • Import config/vD+1_exp in config/config.go and add distro C+1-experimental to init().

Update docs

  • Update internal/doc/main.go to add the new stable spec and reference the new experimental spec in generate().
  • Run generate to regenerate spec docs.
  • Update docs/specs.md.
  • Update docs/upgrading-*.md for the new spec version. Copy the relevant section from Ignition's doc/migrating-configs.md, convert the configs to Butane configs, convert field names to snake case, and update wording as needed. Add subsections for any new Butane-specific features.
  • Note the stabilization in docs/release-notes.md, following the format of previous stabilizations. Drop the -exp version suffix from any notes for the upcoming release.
@travier
Copy link
Member Author

travier commented Sep 6, 2023

We might want to revert 4bd006e from #456 as it does not work with the MCO in 4.14.

@travier
Copy link
Member Author

travier commented Sep 6, 2023

And we might need to stay on Ignition spec 3.4.0 / the latest supported by the MCO.

@travier travier added the jira label Sep 11, 2023
@travier travier mentioned this issue Sep 14, 2023
Closed
1 task
@travier
Copy link
Member Author

travier commented Sep 14, 2023

#490

@travier travier self-assigned this Sep 14, 2023
@travier travier mentioned this issue Sep 14, 2023
Merged
travier added a commit to travier/butane that referenced this issue Sep 21, 2023
@travier
NEWS: Update for 4.14 stabilization
e9d13a8 
Fixes: coreos#488
@travier
Copy link
Member Author

travier commented Sep 21, 2023

On top of the existing mapping that we have here between Butane and Ignition spec versions, it would be nice to get a doc update in https://github.com/openshift/machine-config-operator/tree/master/docs to add a mapping between Ignition specs and the branch in which they are supported / used as default internal spec in the MCO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prestist prestist

@travier travier

Labels
jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stabilize openshift 4.14.0; create openshift 4.15.0-experimental travier/butane
2 participants
@prestist @travier