Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: Use a full base image #338

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Conversation

cgwalters
Copy link
Member

I'm trying to use butane in a Dockerfile as part of a multi-stage
build, and not having anything except the binary in the container
breaks that since Dockerfile wants to invoke things via /bin/sh.

Use ubi8 as a base.

@bgilbert
Copy link
Contributor

bgilbert commented Apr 8, 2022

Hmm, yeah, that makes sense. Let's use registry.fedoraproject.org/fedora:35 or registry.fedoraproject.org/fedora-minimal:35 as a base though. We usually don't use the UBI in our upstreams.

Also, is the path change important for your use case? I'm wondering if that risks a compat break somewhere.

I'm trying to use butane in a `Dockerfile` as part of a multi-stage
build, and not having anything except the binary in the container
breaks that since `Dockerfile` wants to invoke things via `/bin/sh`.
@cgwalters
Copy link
Member Author

We usually don't use the UBI in our upstreams.

There's no restrictions on UBI by design; a specific advantage over fedora as a host here is we don't need to churn this as often.

But we are unlikely to be consistent on this, and it doesn't matter much to me so...switched to fedora.

@cgwalters
Copy link
Member Author

Also, is the path change important for your use case?

Nah, I just thought it was cleaner. Reverted.

@bgilbert bgilbert changed the title Dockerfile: Use ubi as base image Dockerfile: Use a full base image Apr 12, 2022
@bgilbert
Copy link
Contributor

There's no restrictions on UBI by design; a specific advantage over fedora as a host here is we don't need to churn this as often.

Yeah, I know. But I'd feel weird about a community project using a non-community base image. Thanks for making the switch.

@bgilbert bgilbert merged commit 4f48173 into coreos:main Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants