base/v0_2: add sugar to embed Resource from a local file #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can just add translateResource to the parent.
They have an unused error return right now. Convert them to returning a Report.
We'll need these when tr.Translate() starts returning multiple values.
Custom translators might fail if they're doing something at runtime that can't be checked during the validation pass, e.g. reading from an external file. Have custom translators return a Report, and plumb it through to translate.Translate().
lucab
reviewed
May 5, 2020
Have NewTranslator() take an options interface{}, and pass it to
any custom translators registered against that translator. Ensure that
all such custom translators take an options argument with a compatible
type.
Embed a base options struct in common.TranslateOptions and pass it
to the translators.
arithx
approved these changes
May 6, 2020
If `local` is specified instead of `source` or `inline`, read a local file from a base directory and encode it into a data URI. We require the base directory to be specified on the command line, so that transpiling untrusted configs doesn't leak information from the host system by default.
Extend base verifyTranslations() to ensure that all listed exceptions are actually present.
|
Updated. |
arithx
approved these changes
May 7, 2020
|
Hi! /J |
|
@joyartoun Hopefully within the next couple weeks. |
gdonval
added a commit
to gdonval/fedora-coreos-docs
that referenced
this pull request
Mar 3, 2021
The token `local` has been available since coreos/butane#99 but the documentation did not reflect that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
localis specified instead ofsourceorinline, read a local file from a base directory and encode it into a data URI. We require the base directory to be specified on the command line, so that transpiling untrusted configs doesn't leak information from the host system by default.This required plumbing an options struct into custom translators, and plumbing error returns (via a
report.Report) back out.Fixes #83.