Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for sharing vendor directory between multiple projects (--sync from cargo-vendor) #53

Closed
JackWolfard opened this issue Feb 24, 2023 · 5 comments · Fixed by #88
Closed
Labels
enhancement New feature or request triaged This issue was evaluated, no more information is needed

Comments

@JackWolfard
Copy link

cargo vendor supports --sync parameter:

$ cargo vendor --help | rg sync
    -s, --sync <TOML>            Additional `Cargo.toml` to sync and vendor

With this parameter, multiple projects can share the same vendor directory. One complication could be if users want projects which have different platforms but overlapping dependencies to share a directory (#44).

I am willing to contribute this feature.

@cgwalters
Copy link
Member

In general I think we should aim to be a drop-in replacement for cargo vendor, so every feature like this makes sense to me.

One complication could be if users want projects which have different platforms but overlapping dependencies to share a directory (#44).

We should just take the union of the filters, right?

I am willing to contribute this feature.

Cool! Feel free to push a "WIP" style pull request and I'm happy to help review and merge!

@kgrech
Copy link
Contributor

kgrech commented Feb 25, 2023

Thanks @JackWolfard, I also need quite this urgently and I am happy to contribute it as well. When would you have time to work on it? Let me know if you need help with it.

@kgrech
Copy link
Contributor

kgrech commented Feb 25, 2023

We should just take the union of the filters, right?

I wish cargo metadata would just have -sync as well, but it does not :(

@JackWolfard
Copy link
Author

Thanks @JackWolfard, I also need quite this urgently and I am happy to contribute it as well. When would you have time to work on it? Let me know if you need help with it.

I plan to work on it today. Once I open a PR, we can have further discussion there. If you need it quicker than that, feel free to start on it.

@kgrech
Copy link
Contributor

kgrech commented Feb 25, 2023

It is totally fine. HUGE thanks for taking care of it!

@cgwalters cgwalters added triaged This issue was evaluated, no more information is needed enhancement New feature or request labels Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged This issue was evaluated, no more information is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants