WIP: Add support for --sync
#55
Conversation
|
@cgwalters What is the testing strategy for this repo? In both cargo itself and the old cargo-vendor crate, the CLI is mocked to allow for testing within the Rust ecosystem, but in this repo, support for doing a similar strategy seems limited. |
|
The current testing code is https://github.com/coreos/cargo-vendor-filterer/blob/main/ci/selftest.sh
That would be nice yes. Hmm, I bet we could lift https://github.com/alexcrichton/cargo-vendor/blob/master/tests/vendor.rs as is indeed. |
| fn gather_config_from_toml(toml: &Utf8PathBuf, offline: bool) -> Result<Option<VendorFilter>> { | ||
| let meta = new_metadata_cmd(toml, offline) | ||
| .exec() | ||
| .context(format!("Executing cargo metadata for {p} on first run"))?; |
There was a problem hiding this comment.
I think clippy will want with_context instead to only alloc a string on error paths.
|
Waiting on testing changes from #58 to merge before proceeding with development |
|
@JackWolfard What's your stance on reviving this PR? Do you have any cycles to spare for it? |
|
@msirringhaus I do not plan on reviving it, as I am no longer actively using the project. Feel free to pickup where I leftoff. Closing the draft. |
To address #53, this PR adds support for the
--syncflag available in cargo vendor.