This repository has been archived by the owner on Sep 18, 2020. It is now read-only.
config/types/locksmith: add missing fields #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgonyeo
force-pushed
the
locksmith-window
branch
from
85b6c66
to
e995958
Compare
cgonyeo
force-pushed
the
locksmith-window
branch
from
e995958
to
eea4ca2
Compare
cgonyeo
changed the title
|
I just changed this PR to include all missing locksmithd fields. |
cgonyeo
force-pushed
the
locksmith-window
branch
from
eea4ca2
to
bc2a495
Compare
crawford
reviewed
Apr 6, 2017
| @@ -39,3 +66,44 @@ func (r RebootStrategy) Validate() report.Report { | |||
| return report.ReportFromError(ErrUnknownStrategy, report.EntryError) | |||
| } | |||
| } | |||
|
|
|||
| func (s WindowStart) Validate() report.Report { | |||
There was a problem hiding this comment.
Is this how locksmith parses the parameters?
cgonyeo
force-pushed
the
locksmith-window
branch
4 times, most recently
from
515b29d
to
11747e1
Compare
|
Lined the fields up, and nope it isn't. Looks like users can also specify just a time, and not a day. Fixing that now. |
cgonyeo
force-pushed
the
locksmith-window
branch
from
11747e1
to
1b6f482
Compare
|
Not necessarily for this PR, but https://github.com/coreos/locksmith#maximum-semaphore would also be nice to set in CLCs. |
crawford
approved these changes
Apr 11, 2017
This commit adds support for configuring all locksmithd fields, beyond just the reboot strategy.
cgonyeo
force-pushed
the
locksmith-window
branch
from
1b6f482
to
d9eb71c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows users to configure all fields available in locksmithd, including things like reboot windows and etcd endpoints.
Fixes coreos/bugs#1884.