[rhcos-4.7] buildextend-live: add stub grub.cfg to efiboot.img
#2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
05ba856 added an ESP to the ISO's hybrid GPT to help EFI systems that won't boot El Torito from a hard disk. However, when booting from the ESP, GRUB won't read the grub.cfg from the main ISO image, and just drops to a grub prompt. Add a stub grub.cfg that points GRUB to the right place. Fixes: 05ba856 ("buildextend-live: hybridize live ISO for UEFI boot") Fixes: coreos/fedora-coreos-tracker#724 Fixes: coreos/fedora-coreos-tracker#953
At runtime it's immediately overwritten by the GRUB menu, but it shows up in console logs. This will help validate automated tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #2404 and #2409.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2000697.