Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/grub.cfg: Source user.cfg in grub.cfg #2809

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

saqibali-2k
Copy link
Member

@saqibali-2k saqibali-2k commented Apr 11, 2022

To allow users to make changes to the GRUB configuration
we will source a user created user.cfg in the statically defined
grub.cfg.

cgwalters
cgwalters previously approved these changes Apr 12, 2022
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me, needs a rebase to pick up build fix.

@@ -84,4 +84,9 @@ if [ -f "/ignition.firstboot" ]; then
set ignition_firstboot="ignition.firstboot ${ignition_network_kcmdline}"
fi

# Import user defined configuration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's link to coreos/fedora-coreos-tracker#805 or so?

To allow users to make changes to the GRUB configuration
we will source a user created user.cfg in the statically
grub.cfg.
@saqibali-2k
Copy link
Member Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants