Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mantle/kola: machine check enhancements #2968

Merged
merged 5 commits into from
Jul 10, 2022
Merged

mantle/kola: machine check enhancements #2968

merged 5 commits into from
Jul 10, 2022

Conversation

dustymabe
Copy link
Member 

commit 0a7f0ce3a15376078ccc331de898f5f2facb9705
Author: Dusty Mabe <dusty@dustymabe.com>
Date:   Fri Jul 8 10:59:44 2022 -0400

    mantle/kola: extend --ssh-on-test-failure to work when systemd unit failrues are detected
    
    It's frustrating when systemd unit failures are detected but you can't
    just get a shell on the machine to investigate. This patch plumbs
    through the SSHOnTestFailure information into the RuntimeConfig for the
    machine object so we can use that information within CheckMachine to
    dropt into a shell if desired by the user.

commit 9483eb704d8e49f850a702d6ff54cdae71edc51e
Author: Dusty Mabe <dusty@dustymabe.com>
Date:   Fri Jul 8 10:30:58 2022 -0400

    mantle/kola: extend the "skip-base-checks" tag to cover systemd unit failures
    
    This will mean that if someone adds the "skip-base-checks" tag to their
    test systemd unit failures won't cause a failure.

commit e6560685fb93287bd9e2001f2514fd571b365fa1
Author: Dusty Mabe <dusty@dustymabe.com>
Date:   Fri Jul 8 10:24:51 2022 -0400

    mantle/kola: sort RuntimeConfig options alphabetically

commit aa585866459dbb60c34ecdeea2bad842e0630910
Author: Dusty Mabe <dusty@dustymabe.com>
Date:   Fri Jul 8 10:52:59 2022 -0400

    mantle/platform: always run systemd unit checks
    
    In this way we'll always run the unit checks (a change) but we'll continue to
    only fail if we are not allowing failed units.

commit 124fe8d1926c61e352f570308fdccab27be758df
Author: Dusty Mabe <dusty@dustymabe.com>
Date:   Fri Jul 8 10:28:10 2022 -0400

    mantle/platform: enhance failed units check output
    
    Right now the output is on multiple lines if there are multiple failed
    units. Let's make it print on a single line.

@dustymabe dustymabe mentioned this pull request Jul 8, 2022
Merged
cgwalters
cgwalters previously approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

jlebon
jlebon previously approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice series! One minor comment, but cool as is to not waste CI.

mantle/kola/harness.go
@@ -1340,6 +1349,7 @@ func runTest(h *harness.H, t *register.Test, pltfrm string, flight platform.Flig
h.SetSubtests(t.Subtests)

rconf := &platform.RuntimeConfig{
AllowFailedUnits: testSkipBaseChecks(t),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to update the docs in external-tests.md.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just update the PR and merge (no need for another CI run since I'm just updating documentation).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@dustymabe
mantle/platform: enhance failed units check output
e4e854c 
Right now the output is on multiple lines if there are multiple failed
units. Let's make it print on a single line.
@dustymabe
mantle/platform: always run systemd unit checks
59e19e4 
In this way we'll always run the unit checks (a change) but we'll continue to
only fail if we are not allowing failed units.
@dustymabe
mantle/kola: sort RuntimeConfig options alphabetically
dc53a7a
@dustymabe
mantle/kola: extend the "skip-base-checks" tag to cover systemd unit …
f6e2fff 
…failures

This will mean that if someone adds the "skip-base-checks" tag to their
test systemd unit failures won't cause a failure.
@dustymabe
mantle/kola: extend --ssh-on-test-failure to work when systemd unit f…
314b5cd 
…ailrues are detected

It's frustrating when systemd unit failures are detected but you can't
just get a shell on the machine to investigate. This patch plumbs
through the SSHOnTestFailure information into the RuntimeConfig for the
machine object so we can use that information within CheckMachine to
dropt into a shell if desired by the user.
@dustymabe dustymabe dismissed stale reviews from jlebon and cgwalters via 314b5cd July 10, 2022 20:25
@dustymabe dustymabe force-pushed the dusty-kola-check-enhancements branch from 0a7f0ce to 314b5cd Compare July 10, 2022 20:25
@dustymabe dustymabe merged commit e98358a into coreos:main Jul 10, 2022
@dustymabe dustymabe deleted the dusty-kola-check-enhancements branch July 10, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters cgwalters left review comments

@jlebon jlebon jlebon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dustymabe @cgwalters @jlebon