schema/cosa/build: check http response codes in http.Get #2989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
reviewed
Jul 18, 2022
schema/cosa/build.go
Outdated
| @@ -305,6 +305,10 @@ func FetchAndParseBuild(url string) (*Build, error) { | |||
| return nil, err | |||
| } | |||
| defer res.Body.Close() | |||
| if res.StatusCode >= 300 { | |||
There was a problem hiding this comment.
Shouldn't this be e.g.
Suggested change
| if res.StatusCode >= 300 { | |
| if res.StatusCode != 200 { |
instead?
There was a problem hiding this comment.
I'm not super famililiar with http status codes. I thought everything in the 200s was successful, but maybe for our particular case here they don't apply?
This will make the error more clear when trying to run an upgrade test where the fedora-coreos.parent-version` is not actually a real version in the stream history. I'm running a separate pipeline right now and so I'm pushing dev builds into s3 and my parent version is `36.20220716.dev.1`. That doesn't exist in the real testing-devel stream so the code barfs like this: ``` $ cosa kola --rerun --upgrades --no-test-exit-error kola -p qemu-unpriv --output-dir tmp/kola-upgrade run-upgrade --rerun --no-test-exit-error --qemu-image-dir tmp/kola-qemu-cache -v --find-parent-image 2022-07-16T21:52:14Z cli: Started logging at level INFO 2022-07-16T21:52:14Z cli: Started logging at level INFO Error: failed to parse build: invalid character '<' looking for beginning of value ``` This will improve that error message.
dustymabe
force-pushed
the
dusty-fix-error-message
branch
from
574d5e8
to
c0bdd97
Compare
jlebon
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make the error more clear when trying to run
an upgrade test where the fedora-coreos.parent-version`
is not actually a real version in the stream history.
I'm running a separate pipeline right now and so I'm
pushing dev builds into s3 and my parent version is
36.20220716.dev.1. That doesn't exist in the realtesting-devel stream so the code barfs like this:
This will improve that error message.