Stop building gangplank (but keep the code), drop gangplank/vendor
#3001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
stop-building-gangplank
branch
from
cd428e3
to
ed2b548
Compare
|
I think this comment isn't needed any longer: diff --git a/tools/Makefile b/tools/Makefile
index a230b06f9..2aee29562 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -12,7 +12,6 @@ build:
go install github.com/idubinskiy/schematyper@latest
test -e bin/gomarkdoc || \
go install github.com/princjef/gomarkdoc/cmd/gomarkdoc@latest
- # Freeze on 2022-05-26 release of minio for now.
rm -rf pkg
clean:
|
dustymabe
previously approved these changes
Jul 21, 2022
|
I'm noting here that all CI has passed (prior to comment removal). Should be safe to skip CI after comment removal. |
Following the plan in coreos#2860 (comment) This will help us move the Go code to the toplevel; we're going from *three* vendor/ directories to two. Then when we merge the mantle/ bits in we'll go down to the sanity of one vendor/ tree. To emphasize: There's a lot of good ideas in gangplank, we're going to be pulling *some* of this code for sure, so keep the code around to make that explicitly easier.
cgwalters
force-pushed
the
stop-building-gangplank
branch
from
ed2b548
to
0aaf566
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the plan in #2860 (comment)
This will help us move the Go code to the toplevel; we're going from
three vendor/ directories to two. Then when we merge the mantle/
bits in we'll go down to the sanity of one vendor/ tree.
To emphasize: There's a lot of good ideas in gangplank, we're going
to be pulling some of this code for sure, so keep the code around
to make that explicitly easier.