buildextend-live: add coreos-installer config directives to feature map #3083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop checks for older features and assume they always exist now.
On a coreos-installer new enough to ship example-config.yaml, parse that file from the image and convert it to a map of supported directives in features.json. coreos-installer iso/pxe customize can use this to decide whether it can safely use a directive, without us having to manually add a new feature flag every time. xref coreos/coreos-installer@ae860c53
cgwalters
reviewed
Sep 8, 2022
| features['installer-config-directives'] = { | ||
| k: True for k in yaml.safe_load(f) | ||
| } | ||
| except subprocess.CalledProcessError as e: |
There was a problem hiding this comment.
Not a blocker at all but I'd note with the ostree API we can actually more properly distinguish "ENOENT" from "something else went wrong". Kind of tempting to add cat --allow-noent which returns no output or something.
This is much like https://users.rust-lang.org/t/why-i-use-anyhow-error-even-in-libraries/68592
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a coreos-installer new enough to ship
example-config.yaml(coreos/coreos-installer#976), parse that file from the image and convert it to a map of supported directives infeatures.json.coreos-installer iso/pxe customizecan use this to decide whether it can safely use a directive, without us having to manually add a new feature flag every time.While we're here, drop checks for older features and assume they always exist now.