[rhcos-4.11] Backport yumrepos changes; cci.Jenkinsfile changes #3160
Conversation
dustymabe
force-pushed
the
dusty-4.11-backport
branch
from
6ff6def
to
cb59178
Compare
dustymabe
force-pushed
the
dusty-4.11-backport
branch
from
cb59178
to
1e40f47
Compare
|
|
It doesn't work properly against these rhcos- branches anyway. Let's just limit the testing to building the container and running check and unittest tests.
Make the `tarball` argument last. Prep for making it optional. (cherry picked from commit d8a76e9)
For the upcoming yumrepos, we don't want to publish a tarball of it. We still want the git rev information though. Make the tarball argument optional. (cherry picked from commit 606e61b)
Add a new option `--yumrepos` option to `cosa init` to allow import of yum repo files and content sets located outside of the source git. Motivation: RHCOS needs yum repo definitions hidden behind a firewall. Let's add a clean way to import them. Co-authored-by: Jonathan Lebon <jonathan@jlebon.com> (cherry picked from commit ddcba9f)
Use `-type f` to only copy files, and `-maxdepth 1` so we don't recurse into random e.g. test fixtures, etc... (cherry picked from commit 1ab650d)
It's DRYer. Prep for adding another symlink to handle. (cherry picked from commit 9d50294)
Just like the main source config, support passing an existing git checkout to `--yumrepos` for a better local dev experience. (cherry picked from commit 6b37c6f)
dustymabe
force-pushed
the
dusty-4.11-backport
branch
from
1e40f47
to
235f0b7
Compare
|
@dustymabe: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
From a discussion OOB about these backports: in general, it's hard for reviewers to review these and verify that no other backports are missing. We will trust the backporter and focus review on:
- any commits that aren't pure cherry-picks
- any cherry-picks that resulted in merge conflicts (this should be signaled in the commit message, under the
(cherry picked from commit xxxxxxx)footer) - any commits the backporter wants the reviewer to pay special attention to
|
|
No description provided.