[rhcos-4.11-new] Dockerfile: Add repovar for RHCOS repos

[ravanelli]

• We need a way to determine the ocp version for the rhel-8-server-ose repository configuration. It is needed in order to use a single branch for the internal redhat-coreos repo,

Signed-off-by: Renata Ravanelli rravanel@redhat.com

[dustymabe]

I think for this maybe it would be better to put it in the pipeline directly and use environment variables in the form of DNF_VAR_OCP_RELEASE=4.11.

[ravanelli]

I think for this maybe it would be better to put it in the pipeline directly and use environment variables in the form of DNF_VAR_OCP_RELEASE=4.11.

I think the only issue with that is, if someone wants to test it manually and is not aware of it, cosa fetch will fail. Because the var repo definition will be only in the pipeline. If we go for it, would be nice to have something in the cosa fetch help message about it.

[cgwalters]

Currently in Prow jobs we do https://github.com/openshift/os/blob/cc5fef39c588c11892c9250e8a33e2ecb1ee18fa/ci/get-ocp-repo.sh#L3

I think it'd make sense short term to lower support for that into coreos-assembler.

[jlebon]

Hmm, or lower it into rpm-ostree? We could also formalize OCP release references. Something like:

variables:
  osversion: "rhel-8.6"
  ocprelease: "4.12"

repos:
  - rhel-8-baseos
  - rhel-8-appstream
  - rhel-8-fast-datapath
  - rhel-8-server-ose

repovars:
  ocprelease: "${ocprelease}"

mutate-os-release: "${ocprelease}"

[jlebon]

Hmm, or lower it into rpm-ostree?

Proposal in coreos/rpm-ostree#4152.

[dustymabe]

Proposal in coreos/rpm-ostree#4152.

👍 - for the older releases that won't get a new version of rpm-ostree we can just add a file to the COSA image for that stream.

[ravanelli]

👍 - for the older releases that won't get a new version of rpm-ostree we can just add a file to the COSA image for that stream.

Thanks all, for checking it.
As discussed with @dustymabe and @jlebon, I changed this PR to support the old releases only.

[dustymabe]

the old PR was creating a file named OCP_RELEASE. This one is creating a file named ocprelease. Which one is more appropriate?

[jlebon]

the old PR was creating a file named OCP_RELEASE. This one is creating a file named ocprelease. Which one is more appropriate?

Cool either way but slightly prefer the latter for consistency with the traditional other urlvars like releasever and basearch.

[jlebon]

Super minor: We can drop this and assume it exists. Avoids adding another layer to the image. :)

[dustymabe]

LGTM

[openshift-ci]

@ravanelli: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/rhcos	7f9b582	link	true	/test rhcos

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dustymabe]

CI failure is expected: Could not find remote branch release-4.11-new to clone. Merging...