mantle: Clean up firmware handling #3200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prep for switching the default to UEFI on x86_64 in coreos#3159 - Move the logic for default firmware into the constructor - Fix various places that were overriding it with the empty string - Return errors instead of panic on unknown firmware
cgwalters
force-pushed
the
uefi-default-prep
branch
from
cfd3195
to
838bb03
Compare
|
Rebased 🏄 |
jlebon
approved these changes
Nov 30, 2022
dustymabe
reviewed
Nov 30, 2022
| case "aarch64": | ||
| defaultFirmware = "uefi" | ||
| default: | ||
| defaultFirmware = "" |
There was a problem hiding this comment.
do we know what the string is for ppc64le and s390x?
There was a problem hiding this comment.
There isn't one today. It's our own code that translates e.g. uefi into corresponding qemu options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prep for switching the default to UEFI on x86_64 in #3159