Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: Update to fedora 37 #3212

Merged
merged 4 commits into from
Nov 21, 2022
Merged

Dockerfile: Update to fedora 37 #3212

merged 4 commits into from
Nov 21, 2022

Conversation

jmarrero
Copy link
Member

@jmarrero jmarrero commented Nov 17, 2022

Updating as part of: coreos/fedora-coreos-tracker#1223

@dustymabe
Copy link
Member

This one is going to need a little more. Let's remove all frozendeps from build.sh and also the distro-sync edk2-ovmf hack where we are installing it from Fedora 35.

In the least we probably need to hold this until we've migrated 4.13 and 4.12 to the new internal pipeline.

Also we probably need #3190 to land first.

@jmarrero
Copy link
Member Author

@jlebon @dustymabe do we still need:
https://github.com/coreos/coreos-assembler/blob/main/build.sh#L47
or I can remove that line?

@jlebon
Copy link
Member

jlebon commented Nov 18, 2022

This should be unblocked now. 4.12 in the old pipeline has moved to using the rhcos-4.12 branch of cosa, and 4.13 is going to get brought up in the new pipeline where we shouldn't need the edk2-ovmf hack. Can you rebase to pick up #3190 and drop the EFI hack?

@jmarrero
Copy link
Member Author

successfully builds locally too.

@jmarrero
Copy link
Member Author

Looks like the updated gofmt on f37 requires some updates to our go files. Hopefully a quick run fixes it.

@jmarrero
Copy link
Member Author

A lot of files... mostly gofmt, divided into commits. But CI did not like just updating the fedora version.

@dustymabe
Copy link
Member

hmm. if we modify vendored files with gofmt then won't they just get reset the next time we update vendored deps?

@jmarrero
Copy link
Member Author

jmarrero commented Nov 21, 2022

hmm. if we modify vendored files with gofmt then won't they just get reset the next time we update vendored deps?

Yeah..., Looks like make test does not care about vendored files. Fixed the commit. Lot less files now.

@jlebon
Copy link
Member

jlebon commented Nov 21, 2022

In the past, we've usually done a "release" before bumping (really just a git tag would suffice). Let's do that? Also probably would be good to push a versioned tag off of current :main to Quay.io just in case.

@dustymabe
Copy link
Member

Done in https://github.com/coreos/coreos-assembler/releases/tag/v0.15.0 and made a quay tag too.

@dustymabe dustymabe enabled auto-merge (rebase) November 21, 2022 21:25
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlebon jlebon removed the hold waiting on something label Nov 21, 2022
@dustymabe dustymabe merged commit a1c54a9 into coreos:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants