qemu: support '4k' and 'serial' disk options #3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestist
reviewed
Nov 28, 2022
| @@ -107,13 +107,16 @@ func ParseDiskSpec(spec string) (*Disk, error) { | |||
| split := strings.Split(spec, ":") | |||
| var size string | |||
| multipathed := false | |||
| sectorSize := 0 | |||
There was a problem hiding this comment.
What about defaulting it at 512?
There was a problem hiding this comment.
When SectorSize is 0, we just let the default QEMU behaviour kick in, which is 512 logical/physical sector sizes.
There was a problem hiding this comment.
(In Rust this would be an Option<u32> which would better express semantics)
There was a problem hiding this comment.
Ah, I see that makes sense! cool thank you.
|
any chance we could get some documentation for this? |
Support for e.g. `cosa run --add-disk 10G:4k`.
Support for e.g. `cosa run --add-disk 10G:serial=foobar`. This makes it easier to work with multiple disks when testing more complex storage setups.
jlebon
force-pushed
the
pr/add-disk-4k-and-serial
branch
from
7a4de24
to
cc1953d
Compare
Done! |
|
docs look great! will let @prestist review the code. |
cgwalters
approved these changes
Nov 29, 2022
| @@ -107,13 +107,16 @@ func ParseDiskSpec(spec string) (*Disk, error) { | |||
| split := strings.Split(spec, ":") | |||
| var size string | |||
| multipathed := false | |||
| sectorSize := 0 | |||
There was a problem hiding this comment.
(In Rust this would be an Option<u32> which would better express semantics)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.