cmd-buildextend-extensions: fix import_ostree_commit arg #3246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first arg is the workdir, not the OSTree repo path. The previous version still worked because `import_ostree_commit` treated it as a blank `tmp/` and repopulated the repo, which means we were paying the cost of re-extracting the oscontainer and recompressing all the files during the pull-local into the archive repo.
This was referenced Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first arg is the workdir, not the OSTree repo path. The previous version still worked because
import_ostree_committreated it as a blanktmp/and repopulated the repo, which means we were paying the cost of re-extracting the oscontainer and recompressing all the files during the pull-local into the archive repo.