build.sh: freeze grub2 to fix PXE + UEFI tests #3250
Conversation
The metal4k PXE test conveniently also gives us coverage of PXE + UEFI. which would have perhaps caught a recent regression sooner. This matches the tests we run in pipelines.
Was debugging an issue with PXE and only getting a cryptic:
```
Testing scenarios: [pxe-install]
Ignoring verification of signature on metal image
FAIL: pxe-install (uefi + metal) (0s)
running PXE: testing live installer: exit status 1
Error: running PXE: testing live installer: exit status 1
```
The error refers to a command we run, but went ahead and prefixed a
bunch of other errors too while there.
The `pxe-install` build started failing after grub2-2.06-67.fc37 entered
cosa:
Loading kernel
error: ../../grub-core/fs/fshelp.c:257:file
`/rhcos-413.86.202211301346-0-live-kernel-x86_64' not found.
Possibly the same root cause as
coreos/fedora-coreos-tracker#1352.
Freeze on the previous version for now until we figure this out.
| @@ -34,7 +34,7 @@ pod(image: imageName + ":latest", kvm: true, cpu: "${cpuCount}", memory: "${memo | |||
| utils.cosaCmd(cosaDir: "/srv", args: "buildextend-live --fast") | |||
| } | |||
|
|
|||
| kolaTestIso(cosaDir: "/srv", extraArgs4k: "--no-pxe") | |||
There was a problem hiding this comment.
and now if/when we get to locking down the rpm content in COSA itself CI will block the package bump if something like this happens.
|
Unfortunately we're probably going to need this backported too because I think the same change made it into F36: https://src.fedoraproject.org/rpms/grub2/commits/f36 |
Yeah, this is served by our PXE server. I had the same question too, but I think the case here is different. This isn't the target system not using the correct GRUB2, but just whatever the PXE server is serving. So we could match here for our own CI purposes, but we shouldn't expect users/customers to use our EFI binaries also when setting up their PXE servers. So in a way, it may be better to not match since that's likely going to be more common. |
|
Will prep a 4.12 backport once this merges. I think we just haven't hit this yet there because there hasn't been a cosa rebuild since it was introduced maybe? |
Actually, 4.12 is already freezing on an older grub2 because of coreos/fedora-coreos-tracker#1360 so there's nothing to do there, heh. (I guess except adding a comment so we don't lift the freeze even if we address that other issues, but it's pretty unlikely we'll backport the grub2 BIOS fix there. And I wouldn't want to add that comment without testing that PXE + UEFI for sure would fail but I don't have the cycles for that right now.) |
The
pxe-installbuild started failing after grub2-2.06-67.fc37 enteredcosa:
Possibly the same root cause as
coreos/fedora-coreos-tracker#1352.
Freeze on the previous version for now until we figure this out.