[rhcos-4.11] *: address golangci-lint lints #3269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a lot going on here, but mostly a lot of error-checking added. Ignored errors in a few cases. Logged in a few others. Deleted deprecated package golang.org/x/crypto/ssh/terminal in favour of golang.org/x/term. Delete a bunch of unused variables. (cherry picked from commit e3cbf04) jlebon: I didn't backport the migration from `golang.org/x/crypto/ssh/terminal` to `golang.org/x/term` to keep it simple. The main thing I'm interested in is the improved error-handling because we're hitting an issue right now in `rhcos/upgrade.go` which I think would be helped by this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a lot going on here, but mostly a lot of error-checking added. Ignored errors in a few cases. Logged in a few others.
Deleted deprecated package golang.org/x/crypto/ssh/terminal in favour of golang.org/x/term.
Delete a bunch of unused variables.
(cherry picked from commit e3cbf04)
jlebon: I didn't backport the migration from
golang.org/x/crypto/ssh/terminaltogolang.org/x/termtokeep it simple. The main thing I'm interested in is the improved
error-handling because we're hitting an issue right now in
rhcos/upgrade.gowhich I think would be helped by this.