[rhcos-4.12] mantle: overhaul azure authentication #3364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I managed to test this now. Also verified the patch from this branch applies all the way back to 4.9. I'll open those PRs for backport once this one merges. |
This is a partial backport of 50f6205. Rather than doing any library changes here (since the versions of libraries on these older branches are mostly frozen in time) we are just picking up the changes to the credentials file we use as input where we now have a single azureCreds.json rather than two (azureProfile.json and azureAuth.json). In order to support this I still need to get the information back into a AZURE_AUTH_LOCATION formatted file for the old library to be able to read the data. For now we'll just write it out to a temporary file that gets cleaned up immediately after use. This isn't great, but the limited usage here only for older branches executed in our downstream pipeline makes it less of a concern.
|
Ok this has passed all tests, but I need to update the commit message to reference the commit ID that actually merged (50f6205). I'll do a force push and then merge this. |
dustymabe
force-pushed
the
dusty-412-azure-backport
branch
from
58af08f
to
e222029
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial backport of 50f6205. Rather than doing any library changes here (since the versions of libraries on these older branches are mostly frozen in time) we are just picking up the changes to the credentials file we use as input where we now have a single azureCreds.json rather than two (azureProfile.json and azureAuth.json).
In order to support this I still need to get the information back into a AZURE_AUTH_LOCATION formatted file for the old library to be able to read the data. For now we'll just write it out to a temporary file that gets cleaned up immediately after use. This isn't great, but the limited usage here only for older branches executed in our downstream pipeline makes it less of a concern.