-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/building-fcos: add COREOS_ASSEMBLER_ADD_CERTS
#3417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested yet but LGTM
Never mind, it was a VPN issue. |
Perhaps in-addition (or instead) the yumrepos git should also support containing certificates? That'd cover more use cases automatically. |
That doesn't work though if we need the certificate to fetch the yumrepos git itself. |
Overall, this is great as this will significantly simplify the RHCOS docs. |
Docs update in openshift/os#1242 |
This allows devs to use the `cosa` bash alias while working with build content covered by a non-default root certificate.
There's some funkiness in zsh at least that makes alternate values be expanded to a single word instead of multiple words: coreos#3417 (comment) So the flags here don't get expanded correctly. To be compatible to zsh and for consistency, include the `=` sign on all the switches we use.
Prow won't test this. /override ci/prow/rhcos |
@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This allows devs to use the
cosa
bash alias while working with build content covered by a non-default root certificate.