Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/building-fcos: add COREOS_ASSEMBLER_ADD_CERTS #3417

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Apr 3, 2023

This allows devs to use the cosa bash alias while working with build content covered by a non-default root certificate.

travier
travier previously approved these changes Apr 3, 2023
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested yet but LGTM

docs/building-fcos.md Outdated Show resolved Hide resolved
@travier travier self-requested a review April 3, 2023 16:39
@travier
Copy link
Member

travier commented Apr 3, 2023

Looks like this does not work for F37 COSA on F38 Fedora :/

Never mind, it was a VPN issue.

@cgwalters
Copy link
Member

Perhaps in-addition (or instead) the yumrepos git should also support containing certificates? That'd cover more use cases automatically.

@jlebon
Copy link
Member Author

jlebon commented Apr 3, 2023

Perhaps in-addition (or instead) the yumrepos git should also support containing certificates? That'd cover more use cases automatically.

That doesn't work though if we need the certificate to fetch the yumrepos git itself.

@travier
Copy link
Member

travier commented Apr 4, 2023

Overall, this is great as this will significantly simplify the RHCOS docs.

@travier
Copy link
Member

travier commented Apr 4, 2023

Docs update in openshift/os#1242

This allows devs to use the `cosa` bash alias while working with build
content covered by a non-default root certificate.
There's some funkiness in zsh at least that makes alternate values be
expanded to a single word instead of multiple words:

coreos#3417 (comment)

So the flags here don't get expanded correctly. To be compatible to zsh
and for consistency, include the `=` sign on all the switches we use.
@jlebon
Copy link
Member Author

jlebon commented Apr 4, 2023

Prow won't test this.

/override ci/prow/rhcos

@openshift-ci
Copy link

openshift-ci bot commented Apr 4, 2023

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos

In response to this:

Prow won't test this.

/override ci/prow/rhcos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlebon jlebon merged commit 88ee06e into coreos:main Apr 4, 2023
2 checks passed
@jlebon jlebon deleted the pr/mount-bundle branch April 4, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants