This repository has been archived by the owner on Sep 18, 2020. It is now read-only.
Address unit enabling issues #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -87,6 +87,7 @@ Arbitrary systemd units may be provided in the `coreos.units` attribute. | |||
|
|
|||
| - **name**: String representing unit's name. Required. | |||
| - **runtime**: Boolean indicating whether or not to persist the unit across reboots. This is analagous to the `--runtime` argument to `systemd enable`. Default value is false. | |||
| - **enable**: Boolean indicating whether or not to enable the given unit. Default value is false. | |||
There was a problem hiding this comment.
Can you explain what enabling a unit gets you? (Starts after reboot, right?)
There was a problem hiding this comment.
That's one effect enabling a unit can have, but that's not the only thing. It essentially takes the [Install] section of your unit and handles each of the directives you define.
There was a problem hiding this comment.
Perhaps refer to [Install] in the description? enable vs start and what [Install] can do tends to not be obvious to people new to systemd so some hint would be useful.
|
@marineam This feature is just for you ❤️ |
|
|
Fix #69 - A user may provide an `enable` attribute of a unit in their cloud config document. If true, coreos-cloudinit will instruct systemd to enable the associated unit. If false, the unit will not be enabled. Fix #71 - The default enable behavior has been changed from on to off.
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #71
Fix #69