Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coreos-installer install tries to modify grub.cfg to apply console settings even on s390x #1171

Open
jlebon opened this issue Apr 20, 2023 · 0 comments
Labels

Comments

@jlebon
Copy link
Member

jlebon commented Apr 20, 2023

Bug

coreos-installer Version

v0.17.0

Expected Behavior

On s390x, since there's no GRUB config, using coreos-installer install --console or the console key in installer dropins only sets the appropriate karg and doesn't try to look for a GRUB config.

Actual Behavior

On s390x, coreos-installer install --console or the console key in installer dropins tries to look for a GRUB config that doesn't exist and fails the install.

Reproduction Steps

  1. Run coreos-installer install --console on s390x.

Other Information

Output:

coreos-installer install --config-file /etc/coreos/installer.d/mantle.yaml --fetch-retries infinite
Running with arguments: --image-url http://10.0.2.2:34353/fedora-coreos-38.20230419.dev.0-metal.s390x.raw.xz --ignition-file /var/opt/pointer.ign --console ttysclp0 --insecure /dev/vda --fetch -retries infinite
Downloading image from http://10.0.2.2:34353/fedora-coreos-38.20230419.dev.0-metal.s390x.raw.xz
Downloading signature from http://10.0.2.2:34353/fedora-coreos-38.20230419.dev.0-metal.s390x.raw.xz.sig
Failed to fetch signature: fetching signature URL
Signature not found; skipping verification as requested
...
Read disk 479.3 MiB/479.3 MiB (100%)
Writing Ignition config
Error: configuring console
Caused by:
    0: reading grub.cfg
    1: No such file or directory (os error 2)
Resetting partition table
Error: install failed
jlebon added a commit to jlebon/coreos-assembler that referenced this issue Apr 20, 2023
Otherwise, coreos-installer will look for a GRUB config even though
one does not exist.[[1]] Anyway, it seems like we don't need to change
anything on s390x since looking at the testiso logs, one can see that
`console.txt` does contain all the logs already. So don't even bother
setting a karg instead.

Follow-up to 694f96f ("platform/metal: set serial console in PXE and
ISO tests").

[[1]]: coreos/coreos-installer#1171
jlebon added a commit to jlebon/coreos-assembler that referenced this issue Apr 20, 2023
Otherwise, coreos-installer will look for a GRUB config even though
one does not exist.[[1]] Anyway, it seems like we don't need to change
anything on s390x since looking at the testiso logs, one can see that
`console.txt` does contain all the logs already. So don't even bother
setting a karg instead.

Follow-up to 694f96f ("platform/metal: set serial console in PXE and
ISO tests").

[1]: coreos/coreos-installer#1171
jlebon added a commit to coreos/coreos-assembler that referenced this issue Apr 20, 2023
Otherwise, coreos-installer will look for a GRUB config even though
one does not exist.[[1]] Anyway, it seems like we don't need to change
anything on s390x since looking at the testiso logs, one can see that
`console.txt` does contain all the logs already. So don't even bother
setting a karg instead.

Follow-up to 694f96f ("platform/metal: set serial console in PXE and
ISO tests").

[1]: coreos/coreos-installer#1171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants