systemd: remove rudimentary network checking code; depend on NetworkManager #127
Conversation
Previously you could prematurely continue into /usr/bin/coreos-installer before DNS was up. This commit improves network checking such that DNS is checked (if needed) before continuing.
|
hold for now, testing |
systemd/coreos-installer-service
Outdated
| # - This case implies we are going to contact a remote | ||
| # service (most likely fedora infra) so we need to | ||
| # test DNS is working befrore continuing. In this case | ||
| # we'll check the fedora hotspot globally accessible URL: |
There was a problem hiding this comment.
Hmm. NetworkManager has this functionality built in. And on RHEL it uses a RHEL endpoint.
Not blocking this but...is it really worth re-coding that check here?
I think a much simpler common network test is "do we have a default route" - GLib supports this.
What's the harm in having the pull fail later?
There was a problem hiding this comment.
@cgwalters I'm +1 for letting networkmanager handle things here (especially since we're in the real root), but what is a sufficient requirement to add? Currently we have:
Which doesn't seem to be enough.
There was a problem hiding this comment.
Also will the NM check block on having DNS set up?
There was a problem hiding this comment.
What's the harm in having the pull fail later?
The installer seems to barf and not do any retries (probably should be fixed). I get a failed install.
There was a problem hiding this comment.
Thanks! I included that commit in this PR and tested everything together. I'd like to keep my original commit for history, even though it's not needed, in case we need to come back to it for any reason.
From https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/ "Cut the crap! How do I make sure that my service starts after the network is really online?" We were just missing this one. Came out of a discussion about testing for network availability in coreos#127
From https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/ "Cut the crap! How do I make sure that my service starts after the network is really online?" We were just missing this one. Came out of a discussion about testing for network availability in coreos#127
dustymabe
changed the title
|
This is ready for further review |
Now that we have After=network-online.target added in 35b41f9 NetworkManager is handling this for us and we don't need this crude network online checking.
|
Thanks @cgwalters for the help with this |
This adds some retries to curl when downloading Ignition config. It should give us some room for resiliency in case of transient network hiccups. Proactive measure, this has not yet been observed/reported as a direct cause of failures in the wild. Related: coreos#127
This adds some retries to curl when downloading Ignition config. It should give us some room for resiliency in case of transient network hiccups. Proactive measure, this has not yet been observed/reported as a direct cause of failures in the wild. Related: coreos#127
Previously you could prematurely continue into /usr/bin/coreos-installer
before DNS was up. This commit improves network checking such that DNS
is checked (if needed) before continuing.