install: add --delete-karg and --append-karg #268
Conversation
src/install.rs
Outdated
| @@ -254,6 +259,31 @@ fn write_firstboot_kargs(mountpoint: &Path, args: &str) -> Result<()> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| /// Write persistent kernel arguments. | |||
There was a problem hiding this comment.
One thing we need to keep in mind is this needs to trigger a rerun of zipl on s390x.
Hmm...I am increasingly thinking what we want is like a special systemd unit for zipl that checks the mtime of the BLS config and runs zipl if it's changed or something like that.
There was a problem hiding this comment.
Indeed, after installation we do write some s390x specific args parsed from /proc/cmdline
There was a problem hiding this comment.
Ahh yup, goot catch. Hmm, let's circle back on this once #153 merges? It'll make it easier to run zipl. I can open an issue once this merges.
There was a problem hiding this comment.
Sorry, haven't seen this message begore. So, i've already started working on patch to remove all logic in #153 zipl.rs in favour of using --append-karg.
|
Is there also a way to remove persistent arguments as well? (console=ttyS0,1152008n1). It's a good idea in my opinion to emulate the various arguments to rpm-ostree kargs. They are all there for a reason. |
|
I like this but also have a bad feeling about it; I fear this is going to trip many people. In particular, it looks like the logic implemented here is really an |
Yeah, see coreos/fedora-coreos-tracker#533 (comment) related to this. Will rename the switch.
Hmm, though that's no different from eventual kargs-via-Ignition support, right?
Yes, agreed (turns out (See also ostreedev/ostree#1859 -- we'll need to make sure that the implementation of kargs-via-Ignition is ordering aware). |
jlebon
changed the title
|
OK, split out prep patches in #271! |
Prep for next patch.
Factor out the closure and add some basic unit tests.
We don't really want users to use this now. The primary use case was configuring the network from the kernel cmdline. This has been obsoleted by the nicer `--copy-network` approach. We still need to keep supporting it for now though. It's used at least by `coreos-installer.service` to auto-forward some kargs.
This allows users to delete and append kernel arguments from the default set. The major use cases for this are (1) avoiding an additional reboot which might be costly in some situations, and (2) making it easier to troubleshoot the system on firstboot. For more details, see coreos/fedora-coreos-tracker#533 (comment). Closes: coreos/fedora-coreos-tracker#533
This allows users to delete and append kernel arguments from the default
set. The major use cases for this are (1) avoiding an additional reboot
which might be costly in some situations, and (2) making it easier to
troubleshoot the system on firstboot.
For more details, see
coreos/fedora-coreos-tracker#533 (comment).
Closes: coreos/fedora-coreos-tracker#533