Add partition preservation #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashcrow
reviewed
Jul 27, 2020
|
Looks like Travis CI failures on Rust < 1.45
|
ashcrow
reviewed
Jul 27, 2020
ashcrow
reviewed
Jul 27, 2020
bgilbert
reviewed
Jul 27, 2020
bgilbert
changed the title
|
Ready for review! |
lucab
reviewed
Jul 31, 2020
jlebon
reviewed
Jul 31, 2020
|
Updated! |
jlebon
approved these changes
Jul 31, 2020
jlebon
approved these changes
Jul 31, 2020
Add --save-partlabel <glob> and --save-partindex <range> options, which save partition table metadata for existing data partitions and then restore those partitions after writing the image. --save-partlabel takes a glob pattern matching the partition label, and --save-partindex takes a partition number or range of partition numbers (possibly single-ended). For example, to save all partitions with indexes greater than 4, specify "--save-partindex 5-". The specified partitions need not exist. If no --save-* options are specified, no partitions are saved. Multiples of each option can be specified, and/or multiple filters can be specified within a single option argument by separating them with commas. There are corresponding kargs coreos.inst.save_partlabel and coreos.inst.save_partindex, which cannot be repeated but which accept comma-separated patterns. Upon restore, try to reuse the original partition number. If it's not available, renumber the partition to one more than the highest number used so far. For simplicity, never backfill entries earlier in the partition table, even if the corresponding slot is unused. If a saved partition overlaps with the image contents, fail. This can't be detected in advance, so detect the overrun during fetch and stop before the saved partition is clobbered. Also fail if the install image has a partition extending past the end of the image that overlaps with a saved partition. On any failure, after clearing the partition table, restore any saved partitions. In addition, augment partition-table clearing to clear the backup GPT, since some tools may otherwise hallucinate partitions that were overwritten during the install. All of this assumes GPT partitioning both in the image and on disk, so if --save-* options are specified for a DASD target, fail. Fixes coreos#190. Co-authored-by: Glenn West <gwest@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--save-partlabel <glob>and--save-partindex <range>options, which save partition table metadata for existing data partitions and then restore those partitions after writing the image.--save-partlabeltakes a glob pattern matching the partition label, and--save-partindextakes a partition number or range of partition numbers (possibly single-ended). For example, to save all partitions with indexes greater than 4, specify--save-partindex 5-. The specified partitions need not exist. If no--save-*options are specified, no partitions are saved.Multiples of each option can be specified, and/or multiple filters can be specified within a single option argument by separating them with commas. There are corresponding kargs
coreos.inst.save_partlabelandcoreos.inst.save_partindex, which cannot be repeated but which accept comma-separated patterns.Upon restore, try to reuse the original partition number. If it's not available, renumber the partition to one more than the highest number used so far. For simplicity, never backfill entries earlier in the partition table, even if the corresponding slot is unused.
If a saved partition overlaps with the image contents, fail. This can't be detected in advance, so detect the overrun during fetch and stop before the saved partition is clobbered. Also fail if the install image has a partition extending past the end of the image that overlaps with a saved partition.
On any failure, after clearing the partition table, restore any saved partitions. In addition, augment partition-table clearing to clear the backup GPT, since some tools may otherwise hallucinate partitions that were overwritten during the install.
All of this assumes GPT partitioning both in the image and on disk, so if
--save-*options are specified for a DASD target, fail.Fixes #190.