blockdev: strengthen device mapper path detection #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Not tested yet.) |
Apart from the `/dev/mapper` symlinks, there's a bunch of other possible symlinks which also point to the same devmapper device. Instead of trying to catch them all, simply resolve all symlinks and then check that it starts with `dm-`. See also: https://bugzilla.redhat.com/show_bug.cgi?id=1886229#c39
|
OK, yup this fixes https://bugzilla.redhat.com/show_bug.cgi?id=1886229#c39! ✔️ |
|
We should probably add a |
bgilbert
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from the
/dev/mappersymlinks, there's a bunch of other possiblesymlinks which also point to the same devmapper device. Instead of
trying to catch them all, simply resolve all symlinks and then check
that it starts with
dm-.See also: https://bugzilla.redhat.com/show_bug.cgi?id=1886229#c39