This repository has been archived by the owner on Sep 4, 2021. It is now read-only.
contrib: Add hyperkube image build assets #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
| all: container | ||
|
|
||
| hyperkube: | ||
| #TODO(aaron): build from source? |
There was a problem hiding this comment.
Yes, aren't we building our own containers for tectonic releases? If not we will need to at some point to do hot fixes.
There was a problem hiding this comment.
Good point. And we currently do have patches we are carrying for the Kubelet in the OS build.
|
LGTM. Only minor feedback would be to use REPO="quay.io/coreos/hyperkube" instead of the prefix thing since it is a bit more clear. Or maybe even just TAG="quay.io/coreos/hypberkube:v1.4.0". |
aaronlevy
force-pushed
the
hyperkube-image
branch
2 times, most recently
from
0dc2d52
to
73e317a
Compare
This was referenced Jan 21, 2016
aaronlevy
force-pushed
the
hyperkube-image
branch
from
6217231
to
73e87c6
Compare
aaronlevy
changed the title
aaronlevy
force-pushed
the
hyperkube-image
branch
2 times, most recently
from
92c8b1d
to
4e4a016
Compare
aaronlevy
force-pushed
the
hyperkube-image
branch
from
4e4a016
to
e5ff7e4
Compare
aaronlevy
added a commit
that referenced
this pull request
Jan 29, 2016
contrib: Add hyperkube image build assets
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.