Skip to content
This repository has been archived by the owner on Sep 4, 2021. It is now read-only.

kube-aws: use rkt for decrypt-tls-assets #666

Merged
merged 1 commit into from
Sep 15, 2016

Conversation

colhom
Copy link
Contributor

@colhom colhom commented Sep 14, 2016

fixes #545

My investigation has found (at least on my reproductions) that kubelet.service failing for dependency reasons is caused by decrypt-tls-assets.service explicitly listing docker a dependency and failing for that reason.

I took this opportunity to switch us over to rkt for decrypting the TLS assets as well.

\cc @aaronlevy @robszumski @pbx0 @cgag

@@ -137,8 +137,6 @@ coreos:
[Unit]
Description=decrypt kubelet tls assets using amazon kms
Before=kubelet.service
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why leave this? isn't it a noop unless you also have requires?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Install]
RequiredBy=kubelet.service

Dependency injection.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robszumski also keep in mind that ordering constraints in systemd are entirely decoupled from dependency relationships.

Even in the absence of any explicit Required/RequiredBy (or equivalent) relationship between the two services, If both services were being brought up as dependencies of something else, the Before/After relationships between them would still be applied even though the two services do not depend on each other in any way.

@peebs
Copy link
Contributor

peebs commented Sep 14, 2016

\m/ lgtm besides addressing robs comment

@colhom
Copy link
Contributor Author

colhom commented Sep 14, 2016

I see the confusion between dependencies and ordering dependencies pop up a lot in discussion of systemd units here. @pbx0 @robszumski I highly recommend reading this section on Before/After of the systemd docs carefully. The crux is:

Note that this setting is independent of and orthogonal to the requirement dependencies as configured by Requires=.

@robszumski
Copy link
Member

Understood, SGTM

@colhom
Copy link
Contributor Author

colhom commented Sep 15, 2016

We have a successful e2e run on this PR, so I'm going to merge it and fix #670

@colhom colhom merged commit 1ce04ba into coreos:master Sep 15, 2016
@colhom colhom deleted the rkt-decrypt-tls-assets branch September 15, 2016 19:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: make kubelet.service NOT depend on docker.service
3 participants