This repository has been archived by the owner on Sep 18, 2020. It is now read-only.
[WIP- Do not merge] app-admin/kubelet: kubelet-service now runs kubelet via agent #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Environment=KUBELET_AGENT_VERSION=0.1.0 | ||
|
|
||
| # If left empty the kubelet version will be determined by contacting the kube-apiserver. | ||
| Environment=KUBELET_PINNED_VERSION= |
There was a problem hiding this comment.
Nit: KUBELET_VERSION instead?
There was a problem hiding this comment.
I don't feel too strongly here, but, I have a slight preference for KUBELET_PINNED_VERSION (or anything that makes it clear your pinning) I think its a little more clear that, when set, the user is forgoing any auto-updates that are normally available.
Normally, when someone sets a version env, they probably just assume they are just swapping an old version for one they need.
5 tasks
|
Closing for #1735 |
|
Closing for reals ;-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking over from: #1706
This commit changes
kubelet.servicefrom running the kubelet to actually running an agent,kva, that is responsible for launching and updating a kubelet ACI with rkt.The kubetlet is launched as transient unit named
kubelet-v1.2.3.service. The agent will be shipped with the OS.