This repository has been archived by the owner on Sep 18, 2020. It is now read-only.
profiles: build lz4 support into journald #2593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes reading nspawn journals from the host when the container runs systemd built with lz4 support.
|
The one concern to mention with this: I believe with +LZ4 systemd actually defaults journals to lz4, so the logs will start being written in a different format. This could hit people who roll back and then try to read their logs. That being said, I think this is enough of an edge case that we can not worry our heads about it. |
euank
approved these changes
Jun 3, 2017
|
This may also impact rkt, we hit something similar in the past rkt/rkt#3104. |
iaguis
added a commit
to kinvolk/rkt
that referenced
this pull request
Dec 18, 2017
Container Linux enabled lz4 support for journald[1][1], which means logs started being written compressed with the lz4 format instead of xz. Change the note about host's systemd compression support needed from xz to lz4. Also, clarify that this only applies to the coreos and kvm flavors. Users of the host flavor will not be impacted since the systemd used in stage1 will be the same as on the host. [1]: coreos/coreos-overlay#2593
iaguis
added a commit
to kinvolk/rkt
that referenced
this pull request
Dec 18, 2017
Container Linux enabled lz4 support for journald[[1]], which means logs started being written compressed with the lz4 format instead of xz. Change the note about host's systemd compression support needed from xz to lz4. Also, clarify that this only applies to the coreos and kvm flavors. Users of the host flavor will not be impacted since the systemd used in stage1 will be the same as on the host. [1]: coreos/coreos-overlay#2593
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes coreos/bugs#1988.