This repository has been archived by the owner on Mar 28, 2020. It is now read-only.
pkg/cluster: remove disaster recovery/restore and backupmanager #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongchaodeng
reviewed
Nov 7, 2017
pkg/cluster/reconcile.go
Outdated
| c.logger.Infof("Disaster recovery") | ||
| return c.disasterRecovery(L) | ||
| c.logger.Infof("lost quorum") | ||
| return fmt.Errorf("lost quorum") |
There was a problem hiding this comment.
errors.New("lost quorum")
Make it a global var.
|
Test failing. |
fanminshi
changed the title
fanminshi
force-pushed
the
remove_backup_side_car
branch
from
309fb0d
to
7cceb64
Compare
|
fmt check was complaining that some constants in backupmanager are not used. so i remove backupmanager in this pr too. |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #1626