This repository has been archived by the owner on Mar 28, 2020. It is now read-only.
close s3 reader after saving snapshot #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After uploading the snapshot, the backup operator performs a get to ensure that the snapshot was actually saved. The problem is that the resulting get request body is not closed. This causes a leak of http connections. fixes coreos#1965
daniel-garcia
force-pushed
the
fixBackupLeak
branch
from
afc42cf
to
eb6e6d5
Compare
|
Definitely need this, we're seeing memory leaks in backup operator |
|
lgtm thanks! |
|
@daniel-garcia one last thing, could you update the changelog with this fix https://github.com/coreos/etcd-operator/blob/master/CHANGELOG.md#fixed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After uploading the snapshot, the backup operator performs a get
to ensure that the snapshot was actually saved. The problem is that
the resulting get request body is not closed. This causes a leak
of http connections.
fixes #1965