Skip to content
This repository has been archived by the owner on Mar 28, 2020. It is now read-only.

Add option to force path style s3 uploads. #2036

Merged
merged 1 commit into from
Jan 11, 2019

Conversation

ainmosni
Copy link
Contributor

@ainmosni ainmosni commented Jan 8, 2019

This patch adds an option to force path style s3 uploads. This is useful
when a third-party s3 endpoint doesn't support the subdomain style
uploads that's default in s3.

This is a fix for #2035.

@etcd-bot
Copy link
Collaborator

etcd-bot commented Jan 8, 2019

Can one of the admins verify this patch?

2 similar comments
@etcd-bot
Copy link
Collaborator

etcd-bot commented Jan 8, 2019

Can one of the admins verify this patch?

@etcd-bot
Copy link
Collaborator

etcd-bot commented Jan 8, 2019

Can one of the admins verify this patch?

@ainmosni
Copy link
Contributor Author

ainmosni commented Jan 8, 2019

Because of the year change, the generated code verifier complained which prompted me to regenerate all the generated code. This makes the PR a bit more noisy than I'd like. If wanted, I can split up the PRs.

@hexfusion
Copy link
Member

@ainmosni yeah we don't need to update the year just go ahead and remove that and we can go from there. Thanks!

@ainmosni
Copy link
Contributor Author

ainmosni commented Jan 9, 2019

@hexfusion Done, cleaned out the generated code.

@hexfusion
Copy link
Member

@etcd-bot ok to test

@hexfusion
Copy link
Member

@ainmosni I am terribly sorry I skimmed through this quick and didn't realize these dates were machine generated output. So alas you will need to return these dates so that CI will pass. Again sorry about this, and thanks again for the PR and your time.

@ainmosni
Copy link
Contributor Author

ainmosni commented Jan 9, 2019

@hexfusion No problem, I regenerated the code to have the local unit tests pass in the first place. 😁 I've readded them.

@hexfusion
Copy link
Member

@ainmosni this looks good can you rebase these commits as pkg/*:Add option to force path style s3 uploads. and update the CHANGELOG please. Ping me when done and I will get this merged.

This patch adds an option to force path style s3 uploads. This is useful
when a third-party s3 endpoint doesn't support the subdomain style
uploads that's default in s3.
@ainmosni
Copy link
Contributor Author

@hexfusion Done and done.

Copy link
Member

@hexfusion hexfusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hexfusion hexfusion merged commit aeb3e3e into coreos:master Jan 11, 2019
@hexfusion
Copy link
Member

@ainmosni thank you!

@ainmosni
Copy link
Contributor Author

@hexfusion No, thank you, saves me from keeping a custom fork around to use our s3 setup. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants