Skip to content
This repository has been archived by the owner on Mar 28, 2020. It is now read-only.

Add Alibaba Cloud Object Storage Service (OSS) backend for etcd-backu… #2065

Merged
merged 1 commit into from
Mar 28, 2019

Conversation

stormgbs
Copy link
Contributor

@stormgbs stormgbs commented Mar 8, 2019

Add a new type of backend for backing up to and restoring from Alibaba Cloud Object Storage Service (OSS) in the backup and restore operators which have been thoroughly tested in alibaba's production environments.

The design and usage docs are placed into [doc/design/oss_backup.md] and [doc/user/oss_backup.md].

@etcd-bot
Copy link
Collaborator

etcd-bot commented Mar 8, 2019

Can one of the admins verify this patch?

2 similar comments
@etcd-bot
Copy link
Collaborator

etcd-bot commented Mar 8, 2019

Can one of the admins verify this patch?

@etcd-bot
Copy link
Collaborator

etcd-bot commented Mar 8, 2019

Can one of the admins verify this patch?

@hexfusion
Copy link
Member

@stormgbs thank you for the contribution we will try our best to review shortly.

@hexfusion
Copy link
Member

@etcd-bot ok to test

@stormgbs stormgbs force-pushed the master branch 2 times, most recently from 45d3c1c to 4915a0d Compare March 15, 2019 08:03
@xiang90
Copy link
Collaborator

xiang90 commented Mar 15, 2019

@hexfusion

Can you take a look?

doc/design/oss_backup.md Outdated Show resolved Hide resolved
doc/design/oss_backup.md Outdated Show resolved Hide resolved
doc/user/oss_backup.md Outdated Show resolved Hide resolved
doc/user/oss_backup.md Outdated Show resolved Hide resolved
@stormgbs
Copy link
Contributor Author

@xiang90 @WIZARD-CXY @hexfusion @hasbro17 thank you all for review.

doc/user/oss_backup.md Outdated Show resolved Hide resolved
doc/design/oss_backup.md Outdated Show resolved Hide resolved
doc/user/oss_backup.md Outdated Show resolved Hide resolved
doc/user/oss_backup.md Outdated Show resolved Hide resolved
doc/user/oss_backup.md Outdated Show resolved Hide resolved
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stormgbs Thanks for making all the updates.

LGTM after nit.

Copy link
Member

@hexfusion hexfusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits otherwise looks good 👍

pkg/backup/writer/oss_writer.go Show resolved Hide resolved
pkg/controller/backup-operator/oss_backup.go Show resolved Hide resolved
pkg/backup/writer/oss_writer.go Show resolved Hide resolved
@xiang90
Copy link
Collaborator

xiang90 commented Mar 27, 2019

@stormgbs Can you squash all commits into one?

@stormgbs
Copy link
Contributor Author

stormgbs commented Mar 28, 2019

@stormgbs Can you squash all commits into one?

@xiang90 Yes, this is very necessary to squash all commits into one. :)

Copy link
Member

@hexfusion hexfusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xiang90
Copy link
Collaborator

xiang90 commented Mar 28, 2019

@hexfusion can you click the merge button? I do not have the permission anymore :P

@hexfusion hexfusion added this to the v0.9.5 milestone Mar 28, 2019
@hexfusion hexfusion merged commit 86211e9 into coreos:master Mar 28, 2019
@hexfusion
Copy link
Member

@stormgbs thank you for your patience and contribution!

@hexfusion
Copy link
Member

hexfusion commented Mar 29, 2019

@hexfusion can you click the merge button? I do not have the permission anymore :P

@xiang90 perms resolved ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants