Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: build and run statically compiled tests #5088

Closed
wants to merge 1 commit into from

Conversation

heyitsanthony
Copy link
Contributor

/cc @mischief

@mischief
Copy link
Contributor

does -test.cpu 1,2,4 even work with < 4 cpus?

@heyitsanthony
Copy link
Contributor Author

@mischief yes

@gyuho
Copy link
Contributor

gyuho commented Apr 14, 2016

LGTM. /cc @xiang90


export GO15VENDOREXPERIMENT=1

# use vendoring for building tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only execute this code during build?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the exit 0 in the test part covers that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something has created gopath/ on the system that is executing the tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll take a look at it. Could be leftovers from the old version of script?

@mischief
Copy link
Contributor

actually, i apologize, i am still running your old copy of the script (carepkg.sh) so i have not actually executed this pr :-(.

still, i think you should trap to cleanup any stuff created by the execution of the build or the tests.

@heyitsanthony
Copy link
Contributor Author

@mischief sure, fair enough

@xiang90
Copy link
Contributor

xiang90 commented Jun 6, 2016

@mischief Can you take a look? Do you still need this for arm testing?

@pgray
Copy link

pgray commented Jan 23, 2017

Any movement here?

@gyuho gyuho force-pushed the master branch 2 times, most recently from 44ca396 to 4301f49 Compare June 2, 2017 15:53
@stale
Copy link

stale bot commented Apr 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 6, 2020
@stale stale bot closed this Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

5 participants