-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts: build and run statically compiled tests #5088
Conversation
does |
@mischief yes |
LGTM. /cc @xiang90 |
0c9c6df
to
0b336c0
Compare
|
||
export GO15VENDOREXPERIMENT=1 | ||
|
||
# use vendoring for building tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only execute this code during build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the exit 0
in the test part covers that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something has created gopath/
on the system that is executing the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I'll take a look at it. Could be leftovers from the old version of script?
actually, i apologize, i am still running your old copy of the script ( still, i think you should trap to cleanup any stuff created by the execution of the build or the tests. |
@mischief sure, fair enough |
0b336c0
to
80427dd
Compare
@mischief Can you take a look? Do you still need this for arm testing? |
Any movement here? |
44ca396
to
4301f49
Compare
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/cc @mischief