fileutil: rework purge tests so they don't poll #5973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return purgeFile(dirname, suffix, max, interval, stop, nil) | ||
| } | ||
|
|
||
| func purgeFile(dirname string, suffix string, max uint, interval time.Duration, stop <-chan struct{}, purgec chan<- string) <-chan error { |
There was a problem hiding this comment.
So purgec is only for testing?
There was a problem hiding this comment.
probably add a comments about the purgec thing?
|
lgtm. defer to @xiang90 |
|
lgtm after documenting purgec chan. |
heyitsanthony
force-pushed
the
purge-test
branch
from
4956497
to
66292d5
Compare
heyitsanthony
force-pushed
the
purge-test
branch
from
66292d5
to
c920ce0
Compare
|
only failing on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5966