Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestPurgeFileHoldingLockFile fails in semaphore #5966

Closed
heyitsanthony opened this issue Jul 17, 2016 · 1 comment
Closed

TestPurgeFileHoldingLockFile fails in semaphore #5966

heyitsanthony opened this issue Jul 17, 2016 · 1 comment
Milestone

Comments

@heyitsanthony
Copy link
Contributor

2016-07-17 06:59:58.489255 I | fileutil: purged file /tmp/purgefile255810807/0.test successfully
2016-07-17 06:59:58.489421 I | fileutil: purged file /tmp/purgefile255810807/1.test successfully
2016-07-17 06:59:58.489479 I | fileutil: purged file /tmp/purgefile255810807/2.test successfully
2016-07-17 06:59:58.502014 I | fileutil: purged file /tmp/purgefile255810807/3.test successfully
2016-07-17 06:59:58.516947 I | fileutil: purged file /tmp/purgefile255810807/4.test successfully
2016-07-17 06:59:58.526532 I | fileutil: purged file /tmp/purgefile255810807/5.test successfully
2016-07-17 06:59:58.541437 I | fileutil: purged file /tmp/purgefile255810807/6.test successfully
2016-07-17 06:59:58.550338 I | fileutil: purged file /tmp/purgefile439700458/0.test successfully
2016-07-17 06:59:58.550446 I | fileutil: purged file /tmp/purgefile439700458/1.test successfully
2016-07-17 06:59:58.550502 I | fileutil: purged file /tmp/purgefile439700458/2.test successfully
2016-07-17 06:59:58.550553 I | fileutil: purged file /tmp/purgefile439700458/3.test successfully
2016-07-17 06:59:58.550602 I | fileutil: purged file /tmp/purgefile439700458/4.test successfully
2016-07-17 06:59:58.566723 I | fileutil: purged file /tmp/purgefile439700458/5.test successfully
2016-07-17 06:59:58.566804 I | fileutil: purged file /tmp/purgefile439700458/6.test successfully
2016-07-17 06:59:58.678471 I | fileutil: purged file /tmp/purgefile242953684/0.test successfully
2016-07-17 06:59:58.678583 I | fileutil: purged file /tmp/purgefile242953684/1.test successfully
2016-07-17 06:59:58.678643 I | fileutil: purged file /tmp/purgefile242953684/2.test successfully
2016-07-17 06:59:58.689115 I | fileutil: purged file /tmp/purgefile242953684/3.test successfully
2016-07-17 06:59:58.699337 I | fileutil: purged file /tmp/purgefile242953684/4.test successfully
2016-07-17 06:59:58.709703 I | fileutil: purged file /tmp/purgefile242953684/5.test successfully
2016-07-17 06:59:58.723438 I | fileutil: purged file /tmp/purgefile242953684/6.test successfully
2016-07-17 06:59:58.734472 I | fileutil: purged file /tmp/purgefile259074851/0.test successfully
2016-07-17 06:59:58.734582 I | fileutil: purged file /tmp/purgefile259074851/1.test successfully
2016-07-17 06:59:58.734646 I | fileutil: purged file /tmp/purgefile259074851/2.test successfully
2016-07-17 06:59:58.734704 I | fileutil: purged file /tmp/purgefile259074851/3.test successfully
2016-07-17 06:59:58.734761 I | fileutil: purged file /tmp/purgefile259074851/4.test successfully
2016-07-17 06:59:58.745817 I | fileutil: purged file /tmp/purgefile259074851/5.test successfully
2016-07-17 06:59:58.745906 I | fileutil: purged file /tmp/purgefile259074851/6.test successfully
2016-07-17 06:59:58.863553 I | fileutil: purged file /tmp/purgefile523444373/0.test successfully
2016-07-17 06:59:58.863665 I | fileutil: purged file /tmp/purgefile523444373/1.test successfully
2016-07-17 06:59:58.863730 I | fileutil: purged file /tmp/purgefile523444373/2.test successfully
2016-07-17 06:59:58.883533 I | fileutil: purged file /tmp/purgefile523444373/3.test successfully
2016-07-17 06:59:58.916460 I | fileutil: purged file /tmp/purgefile523444373/4.test successfully
2016-07-17 06:59:58.925566 I | fileutil: purged file /tmp/purgefile523444373/5.test successfully
2016-07-17 06:59:58.936863 I | fileutil: purged file /tmp/purgefile523444373/6.test successfully
2016-07-17 06:59:58.947136 I | fileutil: purged file /tmp/purgefile977304816/0.test successfully
2016-07-17 06:59:59.070026 I | fileutil: purged file /tmp/purgefile977304816/1.test successfully
2016-07-17 06:59:59.070117 I | fileutil: purged file /tmp/purgefile977304816/2.test successfully
2016-07-17 06:59:59.070187 I | fileutil: purged file /tmp/purgefile977304816/3.test successfully
2016-07-17 06:59:59.070253 I | fileutil: purged file /tmp/purgefile977304816/4.test successfully
2016-07-17 06:59:59.070317 I | fileutil: purged file /tmp/purgefile977304816/5.test successfully
2016-07-17 06:59:59.070383 I | fileutil: purged file /tmp/purgefile977304816/6.test successfully
--- FAIL: TestPurgeFileHoldingLockFile (0.13s)
    purge_test.go:126: filenames = [1.test 2.test 3.test 4.test 5.test 6.test 7.test 8.test 9.test], want [5.test 6.test 7.test 8.test 9.test]
FAIL
coverage: 58.7% of statements
@xiang90 xiang90 added this to the v3.1.0 milestone Jul 18, 2016
@xiang90
Copy link
Contributor

xiang90 commented Jul 18, 2016

@heyitsanthony I think it is just because the IO was too slow. We already increased the timeout to 100ms. We can do 1s or even 5s for sure. But I feel it is over kill since this happens so infrequent. Also we can try inotify, but I feel it is over kill for this too.

heyitsanthony pushed a commit to heyitsanthony/etcd that referenced this issue Jul 18, 2016
heyitsanthony pushed a commit to heyitsanthony/etcd that referenced this issue Jul 18, 2016
heyitsanthony pushed a commit to heyitsanthony/etcd that referenced this issue Jul 18, 2016
gyuho pushed a commit that referenced this issue Jul 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants