clientv3: drain buffered WatchResponses before resuming #6367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the watcherStream can receive WatchResponses in the middle of a resume, corrupting the stream. Fixes etcd-io#6364
|
lgtm. /cc @xiang90 |
|
lgtm |
|
@xiang90 This is fixing watch problem. Needs backport it to 3.0.x. cc @timothysc |
This was referenced Sep 15, 2016
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Sep 16, 2016
Automatic merge from submit-queue Update etcd godep to 3.0.9 to address TestWatch issues fixes TestWatch issues #32770 addresses: etcd-io/etcd#6367
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the watcherStream can receive WatchResponses in the
middle of a resume, corrupting the stream.
Fixes #6364