Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: coreos/bbolt v1.3.1-coreos.0, add others in glide.yaml #8392

Merged
merged 2 commits into from
Aug 11, 2017

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Aug 10, 2017

Once merged, I will redeploy functional tester cluster.

Copy link
Contributor

@heyitsanthony heyitsanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

@gyuho gyuho changed the title vendor: update coreos/bbolt to v1.3.1-coreos.0 vendor: coreos/bbolt to v1.3.1-coreos.0, add others in glide.yaml Aug 10, 2017
@gyuho gyuho changed the title vendor: coreos/bbolt to v1.3.1-coreos.0, add others in glide.yaml vendor: coreos/bbolt v1.3.1-coreos.0, add others in glide.yaml Aug 10, 2017
@gyuho
Copy link
Contributor Author

gyuho commented Aug 10, 2017

Added others in glide.yaml that were missing from glide.lock.
Now updatedep.sh will output reproducible builds.

Merging in greens.

Thanks.

@gyuho
Copy link
Contributor Author

gyuho commented Aug 10, 2017

Blocked on etcd-io/bbolt#15.

For ppc64.
Reference: etcd-io/bbolt#15 (comment).

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
@gyuho
Copy link
Contributor Author

gyuho commented Aug 11, 2017

@heyitsanthony PTAL.

Seems fixed https://jenkins-etcd.prod.coreos.systems/job/etcd-ci-ppc64/1878/.
Commented on the test (will close etcd-io/bbolt#15).

Thanks.

@heyitsanthony
Copy link
Contributor

lgtm; the new freelist page reuse is probably why it stopped working-- allocation is more efficient

@xiang90
Copy link
Contributor

xiang90 commented Aug 11, 2017

lgtm

@gyuho gyuho removed the WIP label Aug 11, 2017
@gyuho gyuho merged commit 135b7f7 into etcd-io:master Aug 11, 2017
@gyuho gyuho deleted the bbolt branch August 11, 2017 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants