Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvcc: remove unnecessary metrics update code #9300

Merged
merged 1 commit into from
Feb 8, 2018
Merged

Conversation

xiang90
Copy link
Contributor

@xiang90 xiang90 commented Feb 8, 2018

/cc @yudai

After your PR, we now update metrics in defrag func. So no need to call commit to update metrics.

b.batchTx.Commit()

return nil
b.defrag()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return b.defrag()?

@codecov-io
Copy link

Codecov Report

Merging #9300 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9300      +/-   ##
==========================================
- Coverage   75.55%   75.47%   -0.09%     
==========================================
  Files         365      365              
  Lines       30702    30692      -10     
==========================================
- Hits        23198    23164      -34     
- Misses       5879     5907      +28     
+ Partials     1625     1621       -4
Impacted Files Coverage Δ
internal/mvcc/backend/batch_tx.go 77.5% <ø> (-1.08%) ⬇️
internal/mvcc/backend/backend.go 80.09% <100%> (+0.55%) ⬆️
client/members.go 58.87% <0%> (-26.62%) ⬇️
proxy/grpcproxy/register.go 69.44% <0%> (-11.12%) ⬇️
etcdserver/v2_server.go 80.76% <0%> (-3.85%) ⬇️
etcdserver/api/v3election/election.go 64.7% <0%> (-2.95%) ⬇️
pkg/netutil/netutil.go 66.66% <0%> (-2.09%) ⬇️
rafthttp/msgappv2_codec.go 71.3% <0%> (-1.74%) ⬇️
clientv3/leasing/kv.go 90.69% <0%> (-0.67%) ⬇️
pkg/transport/listener_tls.go 65.56% <0%> (-0.67%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b309bc6...1a3a4d1. Read the comment docs.

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks.

@xiang90 xiang90 merged commit fe94f8f into etcd-io:master Feb 8, 2018
@xiang90 xiang90 deleted the simple branch February 8, 2018 18:14
gyuho added a commit that referenced this pull request Jul 3, 2018
#9300

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
gyuho added a commit that referenced this pull request Jul 3, 2018
#9300

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
gyuho added a commit that referenced this pull request Jul 3, 2018
#9300

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants