-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mvcc: remove unnecessary metrics update code #9300
Conversation
internal/mvcc/backend/backend.go
Outdated
b.batchTx.Commit() | ||
|
||
return nil | ||
b.defrag() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return b.defrag()
?
Codecov Report
@@ Coverage Diff @@
## master #9300 +/- ##
==========================================
- Coverage 75.55% 75.47% -0.09%
==========================================
Files 365 365
Lines 30702 30692 -10
==========================================
- Hits 23198 23164 -34
- Misses 5879 5907 +28
+ Partials 1625 1621 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks.
#9300 Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
#9300 Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
#9300 Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
/cc @yudai
After your PR, we now update metrics in defrag func. So no need to call commit to update metrics.