-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge in https://github.com/ashcrow/filetranspiler #76
Comments
I am OK with this. One thing to keep in mind is that this will become something used in the field enough there should be stable builds produced and available. |
Yeah, one thing I am omitting here is the whole spec2 vs spec3 as well as another elephant 🐘 in the room which is MachineConfig vs Ignition. We'll need a debate about that. Plus the fact that parts of fcct high level may not apply to RHCOS (though ideally that's minimized). I think tactically short term, we're not removing the filetranspiler project, just adding functionality to fcct. |
(I would probably say that we should have something like |
Could also be part of the YAML file itself as sugar, e.g.: storage:
local:
- path: relpath/to/local/dir
target: /path/to/extract # or default to / if omitted?
systemd:
local:
- relpath/to/dir/of/units That way the YAML stays self-contained and is easier to use from a config git repo containing all those source files. |
Also worth cross-posting a similar-ish request for having fcct read files from the filesystem directly at coreos/fedora-coreos-tracker#375. |
I like this pattern. It doesn't seem like it would be helpful (yet) in RHCOS land but it's still a much nicer UX. |
Also related here is whether |
Also from OpenShift architects one feedback on things here is a desire to avoid handing lots of binaries over to users. So we may end up e.g. adding Ignition functionality either to |
Proposal:
Semantics:
Possible future extensions:
Thoughts? |
seems reasonable to me |
What defines "files-dir"? |
does |
|
@bgilbert in your proposal, how is user/group ownership handled? |
They wouldn't be set by default (so, root/root), but could be overridden on a per-file basis by creating a |
I propose we merge in the functionality from https://github.com/ashcrow/filetranspiler into this project. Strawman:
--directory
would do what filetranspiler does today.--units
would look like:The text was updated successfully, but these errors were encountered: