overlay: initramfs teardown: add support for coreos.force_persist_ip karg #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also: |
dustymabe
commented
Jun 7, 2021
overlay.d/05core/usr/lib/dracut/modules.d/35coreos-ignition/coreos-teardown-initramfs.sh
Show resolved
Hide resolved
Everything is now newer than the minimimum requirement of NetworkManager 1.26.0.
…karg This karg will override the check to see if Networking Configuration is in the real root (i.e. written by Ignition most likely) and force propagation of initramfs networking anyway. It should only be used in cases where you know exactly what you are doing. For example, in the problem described in https://bugzilla.redhat.com/show_bug.cgi?id=1958930 the networking configs didn't conflict at all, thus this could be used safely. This option will help users who get stuck like they were in that bug to get unstuck easily and then change their strategy later. Fixes: coreos/fedora-coreos-tracker#853
dustymabe
force-pushed
the
dusty-force-persist-ip
branch
from
8199fd3
to
a6c28d2
Compare
darkmuggle
approved these changes
Jun 7, 2021
| forcepropagate=0 | ||
| if dracut_func getargbool 0 'coreos.force_persist_ip'; then | ||
| forcepropagate=1 | ||
| echo "info: coreos.force_persist_ip detected: will force network config propagation" |
There was a problem hiding this comment.
Overall, this looks fine to me, so
/lgtm
That said, I wonder if it makes sense to put something like
cat <<EOM
================================================================
Kernel arg "coreos.force_persist_up=1" should be used rarely
and in exceptional cirucmstances. This is unlikely the bit you
want...
================================================================
EOM
There was a problem hiding this comment.
Yeah I thought about it. I doubt anyone other than us are looking that close in the logs. I figure we can keep the only place it's documented with a fairly large disclaimer about its use.
dustymabe
added a commit
to dustymabe/coreos-installer
that referenced
this pull request
Jun 7, 2021
dustymabe
added a commit
to dustymabe/os
that referenced
this pull request
Jun 8, 2021
Bring in coreos.force_persist_ip support. coreos/fedora-coreos-config#1045 Should help with https://bugzilla.redhat.com/show_bug.cgi?id=1958930 ``` $ git shortlog 8600cd7..43eb876 Dusty Mabe (1): overlay: initramfs teardown: add support for coreos.force_persist_ip karg ```
nikita-dubrovskii
pushed a commit
to nikita-dubrovskii/os
that referenced
this pull request
Jun 18, 2021
Bring in coreos.force_persist_ip support. coreos/fedora-coreos-config#1045 Should help with https://bugzilla.redhat.com/show_bug.cgi?id=1958930 ``` $ git shortlog 8600cd7..43eb876 Dusty Mabe (1): overlay: initramfs teardown: add support for coreos.force_persist_ip karg ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This karg will override the check to see if Networking Configuration is
in the real root (i.e. written by Ignition most likely) and force
propagation of initramfs networking anyway. It should only be used in
cases where you know exactly what you are doing. For example, in the
problem described in https://bugzilla.redhat.com/show_bug.cgi?id=1958930
the networking configs didn't conflict at all, thus this could be used
safely. This option will help users who get stuck like they were in that
bug to get unstuck easily and then change their strategy later.
Fixes: coreos/fedora-coreos-tracker#853