[rhcos-4.9] ignition-ostree-uuid-root.service: add stricter ordering #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the multipath case, we're mounting `/dev/disk/by-label/dm-mpath-root`, not `by-label/root`. Also order against `sysroot.mount` because in the general case, there's actually nothing that prevents the restamping to run at the same time as the mount AFAICT if the `root` karg points to some other device path we didn't predict. See: openshift/os#683 (which hopefully this fixes). (cherry picked from commit 11a11bc)
miabbott
approved these changes
Feb 16, 2022
|
Not sure the CI is going to meaningfully test this, so if you have tested it locally, then I'm OK with merging. |
|
Tested locally and ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the multipath case, we're mounting
/dev/disk/by-label/dm-mpath-root, notby-label/root.Also order against
sysroot.mountbecause in the general case, there'sactually nothing that prevents the restamping to run at the same time as
the mount AFAICT if the
rootkarg points to some other device path wedidn't predict.
See: openshift/os#683 (which hopefully this
fixes).
(cherry picked from commit 11a11bc)