Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next-devel] platforms: add secondary serial console on OpenStack, VirtualBox, VMware #2038

Merged
merged 2 commits into from
Oct 28, 2022
Merged

[next-devel] platforms: add secondary serial console on OpenStack, VirtualBox, VMware #2038

merged 2 commits into from
Oct 28, 2022

Conversation

bgilbert
Copy link
Contributor

Previously, openstack console log <server> was useful for collecting console logs from OpenStack VMs, and FCOS docs included instructions on connecting to the VirtualBox/VMware serial console to get a console log. However, we've disabled the serial console on all three platforms. Re-enable it as a secondary console so those techniques continue to work while avoiding interfering with the primary graphical console.

The OpenStack change is untested.

Fixes: OCPBUGS-2926
Fixes: coreos/fedora-coreos-tracker#567 (comment)

travier
travier previously approved these changes Oct 28, 2022
@cgwalters
Copy link
Member

Hmm I'm a little confused honestly, it seems like we're getting to a point where we're enabling the console on pretty much every platform except metal? If that's getting to be the case I wonder if we should change things to go back to more having a default console setup that can be overridden per-platform - in particular, we have the same kernel arguments across aws/azure/gcp for example.

Anyways, seems OK to me!

dustymabe
dustymabe previously approved these changes Oct 28, 2022
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Is there somewhere we can link to for these new platforms that tells us what the values should be for a serial console on these platforms (similar to the docs we link to for the original entries in this file)?

Previously, `openstack console log <server>` was useful for collecting
console logs from OpenStack VMs, but we disabled serial console output on
OpenStack.  Re-enable it as a secondary console so it gets as much
information as possible without interfering with the graphical console.

Fixes https://issues.redhat.com/browse/OCPBUGS-2926.
The FCOS platform docs for VMware/VirtualBox include instructions on
connecting to the serial console to get a console log, and some users
make use of this functionality:

    coreos/fedora-coreos-tracker#567 (comment)

Re-enable secondary serial consoles on those platforms, so the serial
console gets as much information as possible without interfering with the
graphical console.
@bgilbert bgilbert dismissed stale reviews from dustymabe and travier via 3445898 October 28, 2022 17:26
@bgilbert
Copy link
Contributor Author

@cgwalters Some platforms want serial console only, some want graphical console only, and some want both with serial console either primary or secondary. Since enabling serial console requires us to be thoughtful about how we configure it, I think the current default is useful to ensure we do that.

@dustymabe I've added a link for OpenStack. VirtualBox and VMware both just emulate standard PCs, and how we use the serial ports is up to us, so the links to our docs are in some sense the authoritative ones.

@bgilbert bgilbert merged commit 491ad73 into coreos:next-devel Oct 28, 2022
@bgilbert bgilbert deleted the console/next-devel branch October 28, 2022 21:09
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/os that referenced this pull request Nov 2, 2022
Previously, `openstack console log <server>` was useful for collecting
console logs from OpenStack VMs, and the serial console was similarly
useful in VMware, but we disabled serial console output on both
platforms.  Re-enable it as a secondary console so it gets as much
information as possible without interfering with the graphical console.
Do the same on VirtualBox to stay in sync with FCOS.

Fixes: https://issues.redhat.com/browse/OCPBUGS-2926
xref: coreos/fedora-coreos-config#2038
bgilbert added a commit to openshift-cherrypick-robot/os that referenced this pull request Nov 3, 2022
Previously, `openstack console log <server>` was useful for collecting
console logs from OpenStack VMs, and the serial console was similarly
useful in VMware, but we disabled serial console output on both
platforms.  Re-enable it as a secondary console so it gets as much
information as possible without interfering with the graphical console.
Do the same on VirtualBox to stay in sync with FCOS.

Fixes: https://issues.redhat.com/browse/OCPBUGS-2926
xref: coreos/fedora-coreos-config#2038
bgilbert added a commit to openshift-cherrypick-robot/os that referenced this pull request Nov 3, 2022
Previously, `openstack console log <server>` was useful for collecting
console logs from OpenStack VMs, and the serial console was similarly
useful in VMware, but we disabled serial console output on both
platforms.  Re-enable it as a secondary console so it gets as much
information as possible without interfering with the graphical console.
Do the same on VirtualBox to stay in sync with FCOS.

Fixes: https://issues.redhat.com/browse/OCPBUGS-2926
xref: coreos/fedora-coreos-config#2038
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants