overlay.d/20platform-chrony: additional skip of platform chrony config #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typically we'd think the user would only pass in optional arguments to chrony via OPTIONS in /etc/sysconfig/chronyd but we found a case where a user was providing actual config directives. Let's also exit early out of coreos-platform-chrony-config if /etc/sysconfig/chronyd has been touched. If either /etc/chrony.conf or /etc/sysconfig/chronyd has been touched we just consider the user to own the config and not do anything special based on the platform. Fixes coreos/fedora-coreos-tracker#1449
dustymabe
force-pushed
the
dusty-platform-chrony
branch
from
45daacf
to
51959ae
Compare
jlebon
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically we'd think the user would only pass in optional arguments to chrony via OPTIONS in /etc/sysconfig/chronyd but we found a case where a user was providing actual config directives. Let's also exit early out of coreos-platform-chrony-config if /etc/sysconfig/chronyd has been touched. If either /etc/chrony.conf or /etc/sysconfig/chronyd has been touched we just consider the user to own the config and not do anything special based on the platform.
Fixes coreos/fedora-coreos-tracker#1449