tests/kola: bump minDisk in autosave-xfs tests
#2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actual agcount on a 64G disk depends on the agsize baked in the image, which in turn depends on how large the rootfs was calculated to be (see `estimate-commit-disk-size` in cosa). Since the starting rootfs size will differ on different arches (notably, be larger than x86_64) and minor variations are greatly amplified, the agcount may be lower than expected for a 64G disk and in turn the test can fail. Even on x86_64, the rootfs size can change e.g. in CI builds where we bake non-stripped binaries. Bump the requested disk size to 100G in the test to make it more foolproof. Closes: coreos/fedora-coreos-tracker#1458
|
Verified these tests now pass on an aarch64 machine! |
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual agcount on a 64G disk depends on the agsize baked in the image, which in turn depends on how large the rootfs was calculated to be (see
estimate-commit-disk-sizein cosa).Since the starting rootfs size will differ on different arches (notably, be larger than x86_64) and minor variations are greatly amplified, the agcount may be lower than expected for a 64G disk and in turn the test can fail. Even on x86_64, the rootfs size can change e.g. in CI builds where we bake non-stripped binaries.
Bump the requested disk size to 100G in the test to make it more foolproof.
Closes: coreos/fedora-coreos-tracker#1458