Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc cleanup; deny reprovision tests on ppc64le/rawhide #2413

Merged
merged 5 commits into from
May 10, 2023

Conversation

dustymabe
Copy link
Member

commit 2456f0bc96cc3c2810ef72cf4f70433a22cdcf51
Author: Dusty Mabe <dusty@dustymabe.com>
Date:   Tue May 9 17:28:44 2023 -0400

    denylist: deny reprovision tests on ppc64le/rawhide
    
    They are failing right now. See
    https://github.com/coreos/fedora-coreos-tracker/issues/1489
    
    Note that we can't really deny these tests without hitting a bug
    (feature?) in that if all tests in a kola run are denylisted kola
    will exit with an error. Therefore we add the reprovision label to
    a random test (`ext.config.boot.grub2-install`) so we'll have at
    least one test run.

commit b8caf47438d423c09161d69d403d8fa4d69b1ec8
Author: Dusty Mabe <dusty@dustymabe.com>
Date:   Tue May 9 17:21:00 2023 -0400

    manifests: move systemd-repart to shared manifest
    
    sytemd-repart is in RHEL9 so let's start masking it and testing
    it in RHCOS like we do in FCOS.

commit e8ac8d38522606778fd0b62b78d71bc4234e4583
Author: Dusty Mabe <dusty@dustymabe.com>
Date:   Tue May 9 17:18:18 2023 -0400

    tests: use Fedora 38 container images

commit 1b2e76ec99d56a7e5edbbb13929f2ce3e0468138
Author: Dusty Mabe <dusty@dustymabe.com>
Date:   Tue May 9 17:11:26 2023 -0400

    drop fallback hostname handling
    
    This is dead code that hasn't been included since F36.

commit 22f2c7e1d4f526d16bf48724f35f5330a3f7a775
Author: Dusty Mabe <dusty@dustymabe.com>
Date:   Tue May 9 17:00:25 2023 -0400

    manifests/system-configuration: drop kdump ignition.firstboot workaround
    
    This has made it upstream and is in Fedora and RHEL9.

This has made it upstream and is in Fedora and RHEL9.
This is dead code that hasn't been included since F36.
marmijo
marmijo previously approved these changes May 9, 2023
Copy link
Contributor

@marmijo marmijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sytemd-repart is in RHEL9 so let's start masking it and testing
it in RHCOS like we do in FCOS.

As part of this I had to move the system-configuration.yaml before
the ignition-and-ostree.yaml in the includes list because the
postprocess in the latter deletes everything in /etc/systemd/system/.
They are failing right now. See
coreos/fedora-coreos-tracker#1489

Note that we can't really deny these tests without hitting a bug
(feature?) in that if all tests in a kola run are denylisted kola
will exit with an error. Therefore we add the reprovision label to
a random test (`ext.config.boot.grub2-install`) so we'll have at
least one test run.
@jlebon jlebon merged commit e983073 into coreos:testing-devel May 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants