drop a few no longer required pieces #2434
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dustymabe
commented
May 25, 2023
dustymabe
commented
Mostly a revert of e49baba. This was fixed in dracut some time ago [1] and this is now dead code since we are on F38. [1] dracutdevs/dracut#1777
The service is now pulled in by NetworkManager.service [1] so we can stop adding it as a preset. [1] nmstate/nmstate#2285
dustymabe
commented
May 25, 2023
| @@ -32,6 +32,3 @@ enable rtas_errd.service | |||
| enable clevis-luks-askpass.path | |||
| # Provide status information about the Ignition run | |||
| enable coreos-ignition-write-issues.service | |||
| # Apply network configuration from /etc/nmstate/*.yml | |||
| # We can drop this after merging https://src.fedoraproject.org/rpms/fedora-release/pull-request/255 | |||
| enable nmstate.service | |||
There was a problem hiding this comment.
and.. nmstate.service isn't running in the CI tests and thus failing some tests. I thought that https://github.com/nmstate/nmstate/pull/2285/files would have made this no longer necessary but clearly there is something I'm missing.
There was a problem hiding this comment.
OK it turns out that nmstate.service still needs to be enabled, https://github.com/nmstate/nmstate/pull/2285/files just changed what enablement does.
I added a comment to BZ#2180507 that requests https://src.fedoraproject.org/rpms/fedora-release/pull-request/255 get merged.
|
I'll close this out for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.